ReactiveObjC: upgrade deployment target to 12.0 and eliminate Xcode12 warnings.#40
Merged
Barak Weiss (barakwei) merged 10 commits intoLightricks:masterfrom Aug 27, 2020
Merged
Conversation
Maxim Grabarnik (arangato)
force-pushed
the
feature/xcode12
branch
9 times, most recently
from
6f6c829 to
8e90409
Compare
Maxim Grabarnik (arangato)
changed the title
Author
|
Barak Weiss (@barakwei) this one is ready for review. |
Member
|
Yaron Inger (@StatusReport) Barak Yoresh (@barakyoresh) This PR (among other things) replaces |
Member
Yaron Inger (StatusReport)
left a comment
Yaron Inger (StatusReport)
left a comment
There was a problem hiding this comment.
Overall LGTM, up to what I can say about atomic operations in a limited time review.
Please also run all the tests with TSan to see that it doesn't complain on anything after this migration.
Author
|
Tests with TSan pass as well. No issues spotted. |
Maxim Grabarnik (arangato)
force-pushed
the
feature/xcode12
branch
from
8e90409 to
50557f9
Compare
OSAtomic is deprecated as of iOS10. This change is mainly a cherry pick of upstream PR: ReactiveCocoa#178.
Implement the old less secure logic using modern API. For test it's enough.
Raise them all and not only iOS to stop Xcode copmplainging about: "update to recommended settings".
Maxim Grabarnik (arangato)
force-pushed
the
feature/xcode12
branch
from
50557f9 to
a63d64c
Compare
Author
|
done. |
Maxim Grabarnik (arangato)
force-pushed
the
feature/xcode12
branch
from
a63d64c to
d9e7649
Compare
Barak Weiss (barakwei)
approved these changes
Aug 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a brief summary:
See commit messages for more details.