Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH gtgram: add f_max parameter #9

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

christianbrodbeck
Copy link

Hi there, good to see this is on PYPI now. I am transferring this PR from the original repo (detly#11) where @Borda already approved it

This adds an f_max parameter to gtgram(). This parameter was already in the documentation but missing from the implementation.

@Borda
Copy link
Member

Borda commented Sep 9, 2024

Great addition, shall we a test?

@christianbrodbeck
Copy link
Author

Added a simple test for centre_freqs(); would be more involved for gtgram() because test are parametrized with a dataset test_gammatonegram.py. However I could add a new test picking one entry in the dataset and comparing results when called with or without f_max?

@Borda Borda changed the title ENH gtgram: add f_max parameter ENH gtgram: add f_max parameter Sep 10, 2024
@Borda Borda merged commit 8b52d5a into Lightning-Sandbox:main Sep 10, 2024
9 checks passed
@christianbrodbeck christianbrodbeck deleted the fmax2 branch September 10, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants