Skip to content

Conversation

@Danidapena
Copy link
Collaborator

@Danidapena Danidapena commented Sep 26, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Retries and tires fallback models when response is empty:

demo

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Danidapena Danidapena marked this pull request as draft September 26, 2025 18:19
@Danidapena Danidapena changed the title fix: handle empty repsonses fix: handle empty responses Sep 26, 2025
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 88.04348% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 84%. Comparing base (1854f73) to head (c84aabf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #66   +/-   ##
==================================
+ Coverage    84%   84%   +1%     
==================================
  Files         8     8           
  Lines       466   537   +71     
==================================
+ Hits        390   453   +63     
- Misses       76    84    +8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k223kim
Copy link
Collaborator

k223kim commented Sep 29, 2025

@Danidapena Hey Daniela, looks really good! Just a couple things:

  1. Can we handle errors for such failures (empty responses) so that users will know why it failed?
  2. I don't think async calls are working. It throws such error:
sys:1: RuntimeWarning: coroutine 'LLM._async_chat' was never awaited

@Danidapena Danidapena marked this pull request as ready for review October 6, 2025 14:03
@Danidapena Danidapena merged commit 7a7de4c into main Oct 6, 2025
31 checks passed
@Danidapena Danidapena deleted the handle-empty branch October 6, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants