Bugfix/issue 1274 - HTML export - When image and text divs are rendered one … #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after the other, they are placed NEXT TO each other, instead of one AFTER the other - Fixed.
|
maayanb180
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…after the other, they are placed NEXT TO each other, instead of one AFTER the other - Fixed.
Description of the new Feature/Bugfix
I've added "display: grid" to the rendered divs so that they will be shown correctly.
Related Issue: #1274
Unit-Tests for the new Feature/Bugfix
Cannot write unit-test as this issue is visual
Compatibilities Issues
Is anything broken because of the new code? Any changes in method signatures? No.
Your real name
Maayan Bin Nun
Testing details
Testing code available in the bug description.
I've tested it also in my lab with loads of data and verified that the HTML exports look good with the grid display setting.