forked from ZJONSSON/parquetjs
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/support aws s3 v3 #115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8875554
to
9e083f3
Compare
wilwade
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it!
- ✅ Reviewed
- ✅ Build locally
- ✅ Ran example using the browser build
shannonwells
commented
Jan 30, 2024
|
||
if (trailerBuf.slice(4).toString() != PARQUET_MAGIC) { | ||
if (trailerBuf.subarray(4).toString() != PARQUET_MAGIC) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: slice has been deprecated in favor of subarray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Support AWS S3 V3 streams while retaining support for V2. V2 may be removed later.
Closes #32
with @wilwade , @pfrank13
Solution
Diverge when the stream looks like an AWS V3 stream and handle accordingly. I mostly used @pfrank13 's code workaround.
Change summary:
it.skip
instead of commenting out test code.Steps to Verify:
You should see output like: