Breaking: use new language features #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a syntactic refactoring, makes no difference for consumers. The syntax is supported by all our target environments, but if browserify is used (without babel or similar) it'll fail to parse. Not sure if that constitutes a breaking change. Category: change
|
Rebased to include #96 and applied the same tweaks there. |
vweevers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely private properties, optional chaining and the nullish coalescing operator. This is a syntactic refactoring that makes no difference for most consumers. The syntax is supported by all our target environments, but if browserify is used (without babel or similar) it'll fail to parse.