Change minimum PHP requirements to support non-deprecated versions #239
Conversation
|
I still have more commits to come... |
nbish11
force-pushed
the
use-supported-php-versions
branch
from
8604b93 to
364b564
Compare
…orted before PHP 8
|
@TRPB - If you could please take a look at this and let me know what you think. I've tried to keep the pull request as minimal as possible and focused it around making sure the code will work with PHP versions 7.3 through to 8.1, so I haven't added/removed anything unless it was absolutely necessary. |
|
@TRPB, any thoughts? |
|
Looks good to me, thanks for this, it's been on my list for a while. I'll take a proper look through the changes when I'm back home next week and not on a small boat limited to my phone. |
|
@TRPB Do you think we can merge the code yet? |
|
I was planning to update for PHP 8.4 as I have a project I want to use this on again but we're a long way off. Problem is, ignoring the deprecation notices most of the tests fail for reasons I don't yet understand on 8.4. It looks like some libxml changes to domdocument may have altered the behaviour |
It's not much, but I really like this project and want to start contributing.