new builder options: tagNameProcessors and attrNameProcessors#462
Open
jcsahnwaldt wants to merge 8 commits intoLeonidas-from-XIV:masterfrom
Open
new builder options: tagNameProcessors and attrNameProcessors#462jcsahnwaldt wants to merge 8 commits intoLeonidas-from-XIV:masterfrom
jcsahnwaldt wants to merge 8 commits intoLeonidas-from-XIV:masterfrom
Conversation
…ssItem(x, y) else y
Also fixed a few minor bugs (normalize -> normalizeTags in one spot, version numbers in attrNameProcessors / attrValueProcessors)
Oops, builder doesn't have value processors (yet).
|
Hello guys, when will this be implemented? Thank you 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processItemwas always used in the same way, removed some copied codepackage-lock.jsonto.gitignoreto make git handling simpler. (If you want, we can revert this.)for key, entry of childinbuilder.coffee- should it befor own key...?README.md.Potential issues:
tagNameProcessorsandattrNameProcessors. After this pull request, such users may run into problems because their builder modifies the names in unexpected ways.Possible remedies:
builderTagNameProcessorsandbuilderAttrNameProcessors.tagNameProcessorsandattrNameProcessorsin the builder, e.g.builderProcessors: trueorversion: "0.4.20". Old code doesn't contain this option and thus works as usual.README.md