introduce InlineConfig #2315
Open
introduce InlineConfig #2315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a subset of PR2168. Also renames some OptionsDict methods.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces InlineConfig as a type alias for OptionsDict and renames several methods in the OptionsDict class to improve naming consistency and clarity. The changes also update various backend components to use the new InlineConfig type and parse configuration strings using the new ParseInlineConfig function.
- Renames
OptionsDictmethods for better clarity (e.g.,Exists→HasKey,GetOrDefault→GetOrValue) - Introduces
InlineConfigas a type alias forOptionsDictwith a dedicated parsing function - Updates all backend implementations to use the new naming conventions and types
Reviewed Changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/utils/optionsdict.h | Renames method declarations in OptionsDict class |
| src/utils/optionsdict.cc | Updates to use ParseInlineConfig function |
| src/utils/inline_config.h | Introduces InlineConfig type alias and parsing function |
| src/tools/*.cc | Updates tool files to use renamed OptionsDict methods |
| src/search/classic/stoppers/*.h/.cc | Updates time management components to use InlineConfig |
| src/neural/factory.* | Updates network factory to use InlineConfig |
| src/neural/wrapper.* | Updates wrapper to use InlineConfig |
| src/neural/backends/*.cc | Updates all backend implementations to use InlineConfig and renamed methods |
Comments suppressed due to low confidence (1)
src/neural/backends/sycl/network_sycl.cc.dp.cpp:1
- [nitpick] The include order appears inconsistent.
sycl_common.his included after other headers but it's a local header that should typically be included with other local headers near the top.
/*
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| #include <list> | ||
| #include <memory> | ||
| #include <mutex> | ||
| #include <sycl/sycl.hpp> |
There was a problem hiding this comment.
Duplicate include of <sycl/sycl.hpp> on lines 23 and 31. The second include should be removed.
Suggested change
| #include <sycl/sycl.hpp> |
mooskagh
approved these changes
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of #2168. Also renames some OptionsDict methods.