-
Notifications
You must be signed in to change notification settings - Fork 0
chore(dependencies): upgrade Tailwind CSS to v4 #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
a73a89f to
1de56ac
Compare
1de56ac to
891321d
Compare
libs/ui-react/src/lib/Components/Design-tokens/styles/backdrop.stories.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request upgrades Tailwind CSS from v3 to v4, which is a major version upgrade requiring significant configuration and syntax changes. The PR includes:
- Upgrade to Tailwind CSS v4.1.17 with new v4-specific packages (
@tailwindcss/postcss,@tailwindcss/vite) - Replacement of ESLint plugin (
eslint-plugin-tailwindcss→eslint-plugin-better-tailwindcss) - Migration to v4's new import syntax (
@import 'tailwindcss') - Addition of px units to design tokens for v4 compatibility
- Automatic class reordering throughout components per v4 standards
- Updates to documentation reflecting v4 usage
Reviewed changes
Copilot reviewed 75 out of 76 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Upgrades Tailwind CSS to v4.1.17, adds v4 plugins, replaces ESLint plugin |
| package-lock.json | Lock file updates for new dependencies |
| libs/ui-react/src/styles.css | Migrates to v4 import syntax |
| libs/ui-react/eslint.config.mjs | Configures new ESLint plugin for v4 |
| libs/ui-react/.storybook/main.ts | Updates PostCSS config for v4 |
| libs/ui-react/src/lib/Components/* | Class reordering and syntax updates for v4 |
| libs/design-core/src/themes/css/* | Adds px units to all numeric token values |
| libs/design-core/src/utils/* | Type safety improvements for plugin functions |
| libs/design-core/automations/designTokensEtl.ts | Automation updates to generate v4-compatible tokens |
| apps/app-sandbox-react/vite.config.ts | Migrates to v4 Vite plugin |
| eslint.config.mjs | Removes old Tailwind ESLint config |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4cf242f to
5d44315
Compare
Thanks for finding all those! all should be fixed now |
gamegee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job 💯 ✅
Reviewed and manually tested
I hope I don't miss behavior or interactive updates on components
3dfe440 to
cc3c13d
Compare
aquelemiguel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amount input seems to have lost its animation, could you investigate? Everything else looks proper. Excellent work 🚀
Screen.Recording.2026-01-13.at.10.48.43.mov
e5247e9 to
7ed6564
Compare
Please review commit by commit:
Chore: upgrade Tailwind CSS to v4.1.17:: following https://tailwindcss.com/docs/upgrade-guide
chore: replace eslint-plugin-tailwindcss with eslint-plugin-better-tailwindcss
Refactor: update token values to include 'px' units. : update the
etlfile so now numbers have units for both css and the js files. As in tailwind 4 we need units in the values of css tokens for spacing utilities to work.Refactor: run lint --fix command
Refactor animations: remove 8px offset slide animations from createAnimationsPlugin: removed them as they are no longer used in the select
fix: deactivate tailwind colors: had to desctivate
boxShadowColorandcolorsfrom the config as they were adding the tailwind default colors