Skip to content

Conversation

@aammami-ledger
Copy link
Collaborator

@aammami-ledger aammami-ledger commented Jan 9, 2026

Please review commit by commit:

@vercel
Copy link

vercel bot commented Jan 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
ldls Ready Ready Preview, Comment Jan 13, 2026 4:57pm
ldls-react-native Ready Ready Preview, Comment Jan 13, 2026 4:57pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request upgrades Tailwind CSS from v3 to v4, which is a major version upgrade requiring significant configuration and syntax changes. The PR includes:

  • Upgrade to Tailwind CSS v4.1.17 with new v4-specific packages (@tailwindcss/postcss, @tailwindcss/vite)
  • Replacement of ESLint plugin (eslint-plugin-tailwindcsseslint-plugin-better-tailwindcss)
  • Migration to v4's new import syntax (@import 'tailwindcss')
  • Addition of px units to design tokens for v4 compatibility
  • Automatic class reordering throughout components per v4 standards
  • Updates to documentation reflecting v4 usage

Reviewed changes

Copilot reviewed 75 out of 76 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
package.json Upgrades Tailwind CSS to v4.1.17, adds v4 plugins, replaces ESLint plugin
package-lock.json Lock file updates for new dependencies
libs/ui-react/src/styles.css Migrates to v4 import syntax
libs/ui-react/eslint.config.mjs Configures new ESLint plugin for v4
libs/ui-react/.storybook/main.ts Updates PostCSS config for v4
libs/ui-react/src/lib/Components/* Class reordering and syntax updates for v4
libs/design-core/src/themes/css/* Adds px units to all numeric token values
libs/design-core/src/utils/* Type safety improvements for plugin functions
libs/design-core/automations/designTokensEtl.ts Automation updates to generate v4-compatible tokens
apps/app-sandbox-react/vite.config.ts Migrates to v4 Vite plugin
eslint.config.mjs Removes old Tailwind ESLint config

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aammami-ledger
Copy link
Collaborator Author

Manual visual regression checks:

1. Do/Dont blocks issue

2. Cursor pointer on interactiveIcon doesn't work

For inputs but also other stories

3. Dialog open/close animation.

Enregistrement.de.l.ecran.2026-01-12.a.16.46.53.mov

4. Cursor pointer

Probably the same issue as for the interactiveIcon We miss the cursor pointer for Checkbox, Switch, Tile, Select components

Thanks for finding all those! all should be fixed now

Copy link
Collaborator

@gamegee gamegee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job 💯 ✅
Reviewed and manually tested

I hope I don't miss behavior or interactive updates on components

Copy link
Contributor

@aquelemiguel aquelemiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amount input seems to have lost its animation, could you investigate? Everything else looks proper. Excellent work 🚀

Screen.Recording.2026-01-13.at.10.48.43.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants