Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aptos/e2e test #8799

Draft
wants to merge 2 commits into
base: feat/integrate-aptos
Choose a base branch
from
Draft

Aptos/e2e test #8799

wants to merge 2 commits into from

Conversation

qperrot
Copy link
Contributor

@qperrot qperrot commented Jan 3, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 4:25pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 4:25pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 4:25pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 4:25pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools translations Translation files have been touched cli labels Jan 3, 2025
@qperrot qperrot changed the base branch from develop to feat/integrate-aptos January 3, 2025 15:23
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jan 3, 2025

Desktop Bundle Checks

Comparing 9e122fe against a070f4e.

⚠️ renderer bundle size significantly increased: 36.7mb -> 37.8mb. Please check if this is expected.

Mobile Bundle Checks

Comparing 36fd76a against 72c6f67.

⚠️ main.ios.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.

@live-github-bot live-github-bot bot removed mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools translations Translation files have been touched cli labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant