Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(aptos): improvement to unit tests #8779

Merged
merged 7 commits into from
Jan 6, 2025

Conversation

jccguimaraes
Copy link
Member

@jccguimaraes jccguimaraes commented Dec 31, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Add unit tests for aptos integration:

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 6, 2025 11:13am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 11:13am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 11:13am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2025 11:13am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools translations Translation files have been touched cli labels Dec 31, 2024
@jccguimaraes jccguimaraes changed the base branch from develop to feat/integrate-aptos December 31, 2024 16:41
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Dec 31, 2024

Mobile Bundle Checks

Comparing 396eef9 against 6723a99.

⚠️ main.ios.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.

Desktop Bundle Checks

Comparing 396eef9 against 6723a99.

⚠️ renderer bundle size significantly increased: 36.7mb -> 37.8mb. Please check if this is expected.

@jccguimaraes jccguimaraes marked this pull request as ready for review January 2, 2025 10:23
@jccguimaraes jccguimaraes requested a review from a team as a code owner January 2, 2025 10:23
@live-github-bot live-github-bot bot removed desktop Has changes in LLD mobile Has changes in LLM ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools translations Translation files have been touched cli labels Jan 3, 2025
@jccguimaraes jccguimaraes merged commit 940b324 into feat/integrate-aptos Jan 6, 2025
54 checks passed
@jccguimaraes jccguimaraes deleted the test/LIVE-15127_unit_tests branch January 6, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants