Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aptos): improvements to the bot #8775

Draft
wants to merge 89 commits into
base: develop
Choose a base branch
from

feat(aptos): improve bot specs file

2e4c2d6
Select commit
Loading
Failed to load commit list.
Draft

feat(aptos): improvements to the bot #8775

feat(aptos): improve bot specs file
2e4c2d6
Select commit
Loading
Failed to load commit list.
live-github-bot / @PR β€’ Lint Commit Messages β€’ commitlint (conventional) completed Jan 7, 2025 in 1m 40s

❌ Failure

Lint the Pull Request commit messages according to the conventional commits specification.

πŸ”— Workflow run

🚨 Invalid commit message(s)

One or more commits messages are not formatted correctly.
Please rewrite the git history and reword the commit messages in order to fix this issue. πŸ™

πŸ’‘ Tips:

  • Run pnpm commitlint --from <target branch> locally to test your branch.
  • Run pnpm commit will run a prompt that can walk you through writing a correct commit message.
  • If you are not comfortable with git and git rebase --interactive, here is a nice tutorial.

Commitlint output

β§—   input: fix merge issues
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Removed additional settings from Ledger Live Desktop.
βœ–   subject may not be empty [subject-empty]
βœ–   subject may not end with full stop [subject-full-stop]
βœ–   type may not be empty [type-empty]

βœ–   found 3 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Feat/live 15457 aptos send receive verify get max send balance logic (#8725)

Fix logic for getMaxSendBalance to use hardcoded values
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Added a test file for the LedgerAccount based on Jest.
βœ–   subject may not be empty [subject-empty]
βœ–   subject may not end with full stop [subject-full-stop]
βœ–   type may not be empty [type-empty]

βœ–   found 3 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: test(aptos): Unit tests for Aptos API (#8693)

* chore: save work

* chore: save work

* test: index api
βœ–   subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]

βœ–   found 1 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Fix transaction parsing, after removing sender form aptos input argument (#8691)
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: [QAA] adding Aptos send test (#8450)

* test: adding aptos e2e send test

* feat(aptos): send test

* feat(aptos): uncomment previous tests

* Aptos fixing: History isn't full (#8512)

extending tx to ops with delegation batches and events

* fix(aptos): amount balance (#8462)

* Removing Delegated Balance from the Aptos Footer.

* Prettify addition.

* Removing unecessary code.

* Removing uneeded imports

* Fixing prettier issues.

* Removing the footer and the translation units.

* feat(aptos): add coin feature flag (#8498)

* feat(aptos): add coin feature flag

* feat(aptos): add coin feature flag for testnet

* hw-app-aptos.js moved to lib/ledgerjs/packages/hw-app-aptos. Test file has been copied, but is still not active.

* Repurposed README.md from algorand. removed some unused dependencies from the package.

* Small cosmetic changes.

* Managed to make tests work.

* Feedback from PR.

* chore: add xray ticket id

---------

Co-authored-by: Pedro Semeano <[email protected]>
Co-authored-by: Oleksii <[email protected]>
Co-authored-by: JoΓ£o Martins <[email protected]>
Co-authored-by: JoΓ£o GuimarΓ£es <[email protected]>
Co-authored-by: JoΓ£o Martins <[email protected]>
βœ–   footer's lines must not be longer than 100 characters [footer-max-line-length]
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 3 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Feat/live 15120 aptos bst fix fees visibility for unparsed transaction (#8618)

* Implement generalised parsing of aptos transactions + logic unit tests
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Removing unused imports.
βœ–   subject may not be empty [subject-empty]
βœ–   subject may not end with full stop [subject-full-stop]
βœ–   type may not be empty [type-empty]

βœ–   found 3 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Removed a few files that are not needed after the custom fees removal.
βœ–   subject may not be empty [subject-empty]
βœ–   subject may not end with full stop [subject-full-stop]
βœ–   type may not be empty [type-empty]

βœ–   found 3 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Removed the custom fees from Ledger Live Mobile.
βœ–   subject may not be empty [subject-empty]
βœ–   subject may not end with full stop [subject-full-stop]
βœ–   type may not be empty [type-empty]

βœ–   found 3 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Feedback from PR.
βœ–   subject may not be empty [subject-empty]
βœ–   subject may not end with full stop [subject-full-stop]
βœ–   type may not be empty [type-empty]

βœ–   found 3 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Removing fees from LLD
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Aptos fixing: History isn't full (#8512)

extending tx to ops with delegation batches and events
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Managed to make tests work.
βœ–   subject may not be empty [subject-empty]
βœ–   subject may not end with full stop [subject-full-stop]
βœ–   type may not be empty [type-empty]

βœ–   found 3 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Small cosmetic changes.
βœ–   subject may not be empty [subject-empty]
βœ–   subject may not end with full stop [subject-full-stop]
βœ–   type may not be empty [type-empty]

βœ–   found 3 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Repurposed README.md from algorand. removed some unused dependencies from the package.
βœ–   subject may not be empty [subject-empty]
βœ–   subject may not end with full stop [subject-full-stop]
βœ–   type may not be empty [type-empty]

βœ–   found 3 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: hw-app-aptos.js moved to lib/ledgerjs/packages/hw-app-aptos. Test file has been copied, but is still not active.
βœ–   header must not be longer than 100 characters, current length is 112 [header-max-length]
βœ–   subject may not be empty [subject-empty]
βœ–   subject may not end with full stop [subject-full-stop]
βœ–   type may not be empty [type-empty]

βœ–   found 4 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: fix remaining getAccountUnit imports
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: fix rebase issues
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: support(aptos): update pnpm-lock.yaml after merge conflict
βœ–   type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]

βœ–   found 1 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: support/fix pnpm-lock.yaml after merge conflict
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Remove redundant dependency
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Fix linter and types problems
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Add changeset
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Add Aptos to CLI app
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Remove redundant translations
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Fix bug with the `recepient` field
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Change transaction `function`; add value to `type_arguments`
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Use testnet endpoint if testnet selected
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Implement `getStake` function to calculate stake rewards
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Fix condition with xpub
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Get public key from account id if it can not be retrieved from the device
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Handle the case when account's field `freshAddresses` is empty
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Use mainnet
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Fix typo in dictionary
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Rename `delegatedBalance` to `delegatedAmount`
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Move `compareAddress` helper from `utils` to `logic`
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Fix delegation dictionary
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Fix staked amount
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Remove unused field
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Rename `xpub` field to `publicKey`
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Calculate staked balance; display balance on account page
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Update `pnpm-lock.yaml` after merge with `develop`
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Change transaction praparation, update operation signing
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Implement Aptos in LLM
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: LLD small fixes
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Fix dependencies
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Rework transaction receiving

- Get transactions from the indexer by its version
- Get both transaction types Receive/Send
- Use Aptos API
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]
⚠   body must have leading blank line [body-leading-blank]

βœ–   found 2 problems, 1 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: update `hw-app-aptos` package
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Update dictionary
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Fix issues
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]

βœ–   found 2 problems, 0 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Add transaction configuration

* Gas fee (gas price, gas limit)
* Additional settings (sequence number, exp. timestamp)
* TODO: add texts to the dictionary
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]
⚠   body must have leading blank line [body-leading-blank]

βœ–   found 2 problems, 1 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: Implement base functionality for aptos

* Accounts synchronization
* Recieve
* Send
TODO:
* Implement additional settings for token sending
βœ–   subject may not be empty [subject-empty]
βœ–   type may not be empty [type-empty]
⚠   body must have leading blank line [body-leading-blank]

βœ–   found 2 problems, 1 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

β§—   input: WIP: ledger-live boilerplate

* Add currency
* Add JS Bindings
* Add 'getAddress'
* TODO: Accounts, Send
βœ–   type must be lower-case [type-case]
βœ–   type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]
⚠   body must have leading blank line [body-leading-blank]

βœ–   found 2 problems, 1 warnings
β“˜   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint