test(e2e-desktop): fix swap webview race condition#15624
Open
martijnhjk wants to merge 1 commit intodevelopfrom
Open
test(e2e-desktop): fix swap webview race condition#15624martijnhjk wants to merge 1 commit intodevelopfrom
martijnhjk wants to merge 1 commit intodevelopfrom
Conversation
Contributor
Web Tools Build Status
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the desktop E2E Swap page object to avoid a webview selection race by retrieving the Swap-specific webview via the shared WebViewAppPage.getWebView() helper, improving stability and readability in the affected assertion.
Changes:
- Remove an unused Swap drawer locator (
swapId) fromSwapPage. - Update
checkAssetToto usegetWebView()(Swap-identified webview) and simplify the expected text assertion logic.
martijnhjk
force-pushed
the
support/qaa-fix-36
branch
2 times, most recently
from
6201b97 to
8d1cbae
Compare
martijnhjk
force-pushed
the
support/qaa-fix-36
branch
from
8d1cbae to
5e63512
Compare
martijnhjk
force-pushed
the
support/qaa-fix-36
branch
from
5e63512 to
5708c30
Compare
test(e2e-desktop): get the specific webview test(e2e-desktop): this param is not used test(e2e-desktop): improve code consistency test(e2e-desktop): simplify and improve readability test(e2e-desktop): update step for report
martijnhjk
force-pushed
the
support/qaa-fix-36
branch
from
5708c30 to
f3295fe
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(e2e-desktop): get the specific webview
✅ Checklist
npx changesetwas attached.📝 Description
Avoid calling function on undefined webview and improve readability.
Should address https://github.com/LedgerHQ/qaa-flaky-tests/issues/36
Regression 4.0 ENABLED:
Build: https://github.com/LedgerHQ/ledger-live/actions/runs/23352766676
Report:
Regression 4.0 DISABLED:
Build: https://github.com/LedgerHQ/ledger-live/actions/runs/23352794637
Report: https://ledger-live.allure.green.ledgerlabs.net/allure/reports/18c510c8-7872-49b9-a732-f99669bc0acd/
❓ Context
🧐 Checklist for the PR Reviewers