You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Aleo derivation paths in the ledger-wallet-framework library to align with an incoming device app release. The changes modify both the overridesDerivation specification in the modes configuration and the seedIdentifierPath function to append additional hardened path components ('/0') to the Aleo derivation paths.
Changes:
Updated modes.aleo.overridesDerivation from "44'/683'/<account>" to "44'/683'/<account>'/0'"
Updated seedIdentifierPath function to return "44'/683'/0'/0'" instead of "44'/683'/0" for both aleo and aleo_testnet currencies
Added corresponding changeset entry for the ledger-wallet-framework package
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File
Description
libs/ledger-wallet-framework/src/derivation.ts
Updated Aleo derivation path specifications to include additional hardened path components
.changeset/chilled-rats-sneeze.md
Added changeset documenting the derivation path update as a minor version bump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
This PR updates the derivation path for Aleo family to match the incoming device app release.
❓ Context
🧐 Checklist for the PR Reviewers