Skip to content

[LWDM] fix(aleo): update derivation path#15617

Open
mdomanski-ext-ledger wants to merge 1 commit intodevelopfrom
fix/aleo-update-derivation-path
Open

[LWDM] fix(aleo): update derivation path#15617
mdomanski-ext-ledger wants to merge 1 commit intodevelopfrom
fix/aleo-update-derivation-path

Conversation

@mdomanski-ext-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Aleo derivation path

📝 Description

This PR updates the derivation path for Aleo family to match the incoming device app release.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

⚠️ E2E tests are required

Changes detected require e2e testing before merge (even before asking for any review).

🖥️ Desktop

-> Run Desktop E2E

  • Select "Run workflow"
  • Branch: fix/aleo-update-derivation-path
  • Device: nanoSP or stax

📱 Mobile

-> Run Mobile E2E

  • Select "Run workflow"
  • Branch: fix/aleo-update-derivation-path
  • Device: nanoX

Affected coins modules: aleo

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Aleo derivation paths in the ledger-wallet-framework library to align with an incoming device app release. The changes modify both the overridesDerivation specification in the modes configuration and the seedIdentifierPath function to append additional hardened path components ('/0') to the Aleo derivation paths.

Changes:

  • Updated modes.aleo.overridesDerivation from "44'/683'/<account>" to "44'/683'/<account>'/0'"
  • Updated seedIdentifierPath function to return "44'/683'/0'/0'" instead of "44'/683'/0" for both aleo and aleo_testnet currencies
  • Added corresponding changeset entry for the ledger-wallet-framework package

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
libs/ledger-wallet-framework/src/derivation.ts Updated Aleo derivation path specifications to include additional hardened path components
.changeset/chilled-rats-sneeze.md Added changeset documenting the derivation path update as a minor version bump

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

Web Tools Build Status

Build Status Deployment
Web Tools Build ✅ Deployed https://web-tools-5k2nftd6h-ledger-hq-prd.vercel.app
Native Storybook Build ⏭️ Skipped
React Storybook Build ⏭️ Skipped

@mdomanski-ext-ledger mdomanski-ext-ledger force-pushed the fix/aleo-update-derivation-path branch from 3d6ef9f to e0de96e Compare March 20, 2026 14:14
@mdomanski-ext-ledger mdomanski-ext-ledger requested a review from a team as a code owner March 20, 2026 14:14
@live-github-bot live-github-bot bot added coin-modules shared-lib Label added for automated tagging of PRs labels Mar 20, 2026
@live-github-bot live-github-bot bot changed the title fix(aleo): update derivation path [LWDM] fix(aleo): update derivation path Mar 20, 2026
@sonarqubecloud
Copy link

@mdomanski-ext-ledger
Copy link
Contributor Author

E2E run with @family-aleo filter: https://github.com/LedgerHQ/ledger-live/actions/runs/23345535745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants