Skip to content

[LWM] feat(mobile): switch device mode from polling to event#15600

Open
aussedatlo wants to merge 1 commit intodevelopfrom
feat/LIVE-25566-mobile-event-transport
Open

[LWM] feat(mobile): switch device mode from polling to event#15600
aussedatlo wants to merge 1 commit intodevelopfrom
feat/LIVE-25566-mobile-event-transport

Conversation

@aussedatlo
Copy link
Contributor

Summary

  • Switch setDeviceMode from "polling" to "event" in the mobile live-common setup
  • The event-based transport is more stable and achieves parity with the desktop transport, ensuring consistent behavior across platforms

Jira: LIVE-25566

Test plan

  • Verify BLE and USB device connections work correctly on mobile
  • Confirm firmware update flow (OTA) completes successfully
  • Check app install/uninstall via Manager still works
  • Test on both iOS and Android

Made with Cursor

Switch the device transport mode from "polling" to "event" for improved
stability. The event-based transport is more reliable and achieves parity
with the desktop transport, ensuring a consistent behavior across platforms.

Made-with: Cursor
@aussedatlo aussedatlo requested a review from a team as a code owner March 20, 2026 09:21
Copilot AI review requested due to automatic review settings March 20, 2026 09:21
@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Mar 20, 2026
@live-github-bot live-github-bot bot changed the title feat(mobile): switch device mode from polling to event [LWM] feat(mobile): switch device mode from polling to event Mar 20, 2026
@github-actions
Copy link
Contributor

⚠️ E2E tests are required

Changes detected require e2e testing before merge (even before asking for any review).

🖥️ Desktop

-> Run Desktop E2E

  • Select "Run workflow"
  • Branch: feat/LIVE-25566-mobile-event-transport
  • Device: nanoSP or stax

📱 Mobile

-> Run Mobile E2E

  • Select "Run workflow"
  • Branch: feat/LIVE-25566-mobile-event-transport
  • Device: nanoX

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Ledger Live mobile live-common initialization to use the event-based hardware action implementation mode instead of polling, aiming to align transport behavior with desktop and improve stability.

Changes:

  • Switch setDeviceMode from "polling" to "event" in the mobile live-common setup.


setGlobalOnBridgeError(e => logger.critical(e));
setDeviceMode("polling");
setDeviceMode("event");
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes user-facing device connectivity behavior on mobile (switching the global hw app action implementation mode). Per repo policy, PRs that change user-facing behavior should include a Changeset (via pnpm changeset) so the release notes/versioning capture it.

Suggested change
setDeviceMode("event");

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

Web Tools Build Status

Build Status Deployment
Web Tools Build ✅ Deployed https://web-tools-4bjx44q98-ledger-hq-prd.vercel.app
Native Storybook Build ⏭️ Skipped
React Storybook Build ⏭️ Skipped

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mobile Has changes in LLM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants