[LWM] feat: add total market cap and top gainers losers to notification tog…#15583
Open
mitchellv-ledger wants to merge 1 commit intodevelopfrom
Open
[LWM] feat: add total market cap and top gainers losers to notification tog…#15583mitchellv-ledger wants to merge 1 commit intodevelopfrom
mitchellv-ledger wants to merge 1 commit intodevelopfrom
Conversation
live-github-bot
bot
changed the title
Contributor
Web Tools Build Status
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new notification preference toggles for “Total Market Cap” and “Top Gainers and Losers” in Ledger Live Mobile settings, wiring them through persisted settings state, analytics, and Braze user attributes.
Changes:
- Add two new notification settings keys (
totalMarketCap,topGainersLosers) and expose them in the Notifications settings screen. - Propagate the new preferences to Braze (
updateUserPreferences) and Segment extra properties. - Add English i18n strings and extend an existing NotificationsPrompt integration test coverage.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/ledger-live-mobile/src/screens/Settings/Notifications/index.tsx | Adds two new notification rows and mapping entries for translations/tracking. |
| apps/ledger-live-mobile/src/reducers/types.ts | Extends NotificationsSettings with two new boolean fields. |
| apps/ledger-live-mobile/src/reducers/settings.ts | Sets default values for the new notification settings in INITIAL_STATE. |
| apps/ledger-live-mobile/src/notifications/braze.ts | Sends the new opt-in attributes to Braze. |
| apps/ledger-live-mobile/src/mvvm/features/NotificationsPrompt/integrations/NotificationsPrompt.test.tsx | Updates integration test to include the two new categories in feature flag params. |
| apps/ledger-live-mobile/src/mvvm/components/MainTabBar/constants.ts | Parentheses-only change in getLabelKey return expression. |
| apps/ledger-live-mobile/src/locales/en/common.json | Adds English strings for the two new notification toggles. |
| apps/ledger-live-mobile/src/analytics/segment.ts | Adds the new opt-in flags to Segment extra properties. |
| .changeset/shiny-falcons-grin.md | Changeset for live-mobile minor bump. |
apps/ledger-live-mobile/src/screens/Settings/Notifications/index.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
mitchellv-ledger
force-pushed
the
feat/LIVE-26064_notification_toggles
branch
from
d1d186c to
5654c9c
Compare
…gles chore: fix import settings
mitchellv-ledger
force-pushed
the
feat/LIVE-26064_notification_toggles
branch
from
5654c9c to
02d3621
Compare
|
LL782
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…gles
✅ Checklist
npx changesetwas attached.📝 Description
Adds total market cap and top gainers losers notification toggles in settings.
❓ Context
🧐 Checklist for the PR Reviewers