-
Notifications
You must be signed in to change notification settings - Fork 0
feat/add bottomsheet #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat/add bottomsheet #277
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
47b95a2 to
262baec
Compare
262baec to
65a89ee
Compare
77b54eb to
3d543af
Compare
3d543af to
4dff52a
Compare
4dff52a to
383cac9
Compare
383cac9 to
1b89f4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a BottomSheet component to the React Native UI library, built on top of @gorhom/bottom-sheet v5. The implementation includes support for various scrollable content types, dynamic sizing, custom styling, and gesture handling.
- Adds new BottomSheet component with header, backdrop, and handle customization
- Integrates react-native-gesture-handler and related dependencies
- Implements scrollable component wrappers (View, ScrollView, FlatList, VirtualizedList)
- Adds useMergedRef utility for combining React refs with cleanup support
- Updates version constraints for nativewind from caret (^) to tilde (~) ranges
Reviewed Changes
Copilot reviewed 28 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added @gorhom/bottom-sheet, react-native-gesture-handler, react-native-worklets dependencies; updated version constraints |
| package-lock.json | Updated lockfile with new dependencies and version updates |
| libs/utils-shared/src/lib/use-merge-ref/* | New utility for merging React refs with cleanup function support |
| libs/ui-rnative/src/lib/Components/BottomSheet/* | Core BottomSheet implementation with header, backdrop, handle, and scrollable components |
| libs/ui-rnative/src/lib/Components/ThemeProvider/* | Added web platform check to prevent appearance API calls on web |
| libs/ui-rnative/src/lib/utils/index.ts | Fixed duplicate export of string-utils |
| libs/ui-rnative/.storybook/* | Added gesture handler provider decorator and updated logo path |
| apps/app-sandbox-rnative/* | Added BottomSheet example to sandbox app with gesture handler setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6de3007 to
42850c7
Compare
7e3a931 to
46a9219
Compare
46a9219 to
c89a809
Compare
c89a809 to
78c90f2
Compare
3733304 to
c4d5c93
Compare
c4d5c93 to
78e96c2
Compare
Signed-off-by: Simon Bruneaud <[email protected]>
Signed-off-by: Simon Bruneaud <[email protected]>
Signed-off-by: Simon Bruneaud <[email protected]>
Signed-off-by: Simon Bruneaud <[email protected]>
Signed-off-by: Simon Bruneaud <[email protected]>
Signed-off-by: Simon Bruneaud <[email protected]>
78e96c2 to
fe35d42
Compare
Signed-off-by: Simon Bruneaud <[email protected]>
fe35d42 to
dacd5e7
Compare
See Pull Request overview (by copilot)
#277 (review)