Skip to content

Conversation

@gamegee
Copy link
Collaborator

@gamegee gamegee commented Oct 24, 2025

See Pull Request overview (by copilot)
#277 (review)

@gamegee gamegee requested a review from a team as a code owner October 24, 2025 16:16
@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ldls Ready Ready Preview Comment Nov 6, 2025 9:14am
ldls-react-native Ready Ready Preview Comment Nov 6, 2025 9:14am

@gamegee gamegee force-pushed the feat/add-bottomsheet branch 2 times, most recently from 47b95a2 to 262baec Compare October 24, 2025 16:18
@gamegee gamegee force-pushed the feat/add-bottomsheet branch from 262baec to 65a89ee Compare October 24, 2025 16:36
@gamegee gamegee force-pushed the feat/add-bottomsheet branch from 77b54eb to 3d543af Compare October 27, 2025 16:20
@gamegee gamegee force-pushed the feat/add-bottomsheet branch from 3d543af to 4dff52a Compare October 28, 2025 16:10
@gamegee gamegee force-pushed the feat/add-bottomsheet branch from 4dff52a to 383cac9 Compare October 31, 2025 09:05
@gamegee gamegee force-pushed the feat/add-bottomsheet branch from 383cac9 to 1b89f4b Compare October 31, 2025 13:29
@gamegee gamegee requested a review from Copilot October 31, 2025 13:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a BottomSheet component to the React Native UI library, built on top of @gorhom/bottom-sheet v5. The implementation includes support for various scrollable content types, dynamic sizing, custom styling, and gesture handling.

  • Adds new BottomSheet component with header, backdrop, and handle customization
  • Integrates react-native-gesture-handler and related dependencies
  • Implements scrollable component wrappers (View, ScrollView, FlatList, VirtualizedList)
  • Adds useMergedRef utility for combining React refs with cleanup support
  • Updates version constraints for nativewind from caret (^) to tilde (~) ranges

Reviewed Changes

Copilot reviewed 28 out of 31 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Added @gorhom/bottom-sheet, react-native-gesture-handler, react-native-worklets dependencies; updated version constraints
package-lock.json Updated lockfile with new dependencies and version updates
libs/utils-shared/src/lib/use-merge-ref/* New utility for merging React refs with cleanup function support
libs/ui-rnative/src/lib/Components/BottomSheet/* Core BottomSheet implementation with header, backdrop, handle, and scrollable components
libs/ui-rnative/src/lib/Components/ThemeProvider/* Added web platform check to prevent appearance API calls on web
libs/ui-rnative/src/lib/utils/index.ts Fixed duplicate export of string-utils
libs/ui-rnative/.storybook/* Added gesture handler provider decorator and updated logo path
apps/app-sandbox-rnative/* Added BottomSheet example to sandbox app with gesture handler setup

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants