Fully featured FIO app #12

relatko · 2023-01-27T16:23:31Z

Main new features of the app:

The app now supports 25 various signTx actions instead of one.
- Two actions contain Diffie-Hellman encrypted shared secret.
New Decode shared secret call

Tutorial for the new app is available at:
https://kb.fioprotocol.io/user-guides/ledger-fio-app-tutorial
The new features are only deployed on the beta site: https://beta-dashboard.fioprotocol.io

The folder /doc/security contains documentation for security review.

Contains detailed description of ledger app code changes.
Gives code modularization into smaller chunks. Besides this it gives suggested order in which to review the chunks. We made our review based on this order.
Contains app architecture description from security perspective.

Merge ledger hq changes, change icons

Build improvements, Speculos tests

They behave similar to hash functions

The code now pases original integration tests

This way derivation path is available for DH encoding

Changing newfundsreq data content format, introduce error specific to integrity checks.

applying parse not validate as it is supposed

Derivation path is serializes LE Remove unnecessary endian functions

List of hashes for integrity check is not updated at the moment...

Documentation and cleanup

Fix on device get app version test

xchapron-ledger · 2023-05-25T12:32:42Z

MakefileLocal.mk

This whole file could be simplified using up to date app-boilerplate/makefile as a reference.

xchapron-ledger · 2023-05-25T12:37:57Z

src/keyDerivation.c

TRY CATCH usage can be remove using _no_throw version of os_perso_derive_ and cx_ functions.
You could also use the helper from https://github.com/LedgerHQ/ledger-secure-sdk/blob/master/lib_standard_app/crypto_helpers.h.

I refactored all code handling intermediate (not to be returned) secrets into keyDerivation.c and diffieHellman.c (+ hash.h) files where errors are handled by returning error value.

xchapron-ledger · 2023-05-25T12:39:24Z

src/main.c

Many function can be removed if using the new standard_app lib from the SDK.
This improves the app code readability and helps removing some classical bugs.

relatko · 2023-06-10T15:54:32Z

Added guideline enforcer + fixed issues it found.
Bumped containers to most recent versions (build + speculos). Resolved breaking changes.

Fixed: - Missing input value validation - Potential missing secret wiping from stack after use - String manipulation - Pointer arithmetic on void pointer - Trivial swich-case statements were removed - Replaced certain other memset calls

tdejoigny-ledger · 2023-09-04T10:44:09Z

hello @relatko, the CI checks shall be green to submit the PR. Please make the changes to have the CI green. Thank you.

Remove exceptions from public and private key code

src/keyDerivation.c

Bump containers, update issues

relatko added 30 commits April 6, 2022 09:17

Merge pull request #8 from vacuumlabs/merge_LedgerHQ_changes

6dccd52

Merge ledger hq changes, change icons

Add containerized build

7b115c3

Make CI more continious

6cb7c7b

Start and stop Speculos

1117cbb

Makefile containing JS related goals

01eda26

Infrastructure

0bf8219

Speculos tests documentation + .gitignore

7c079db

Remove unused files

bf361ab

Ass Diffie-Hellman encryption support

569838c

Merge pull request #9 from vacuumlabs/build_in_container

fcc4b96

Build improvements, Speculos tests

Fix formatting

62f3f1c

Introduce NO_PULL option (for build and speculos)

7fc2d3d

Add sign tx commands integrity checking tools

8efc041

Update github workflows linter to 12

0c17bd3

Refactor tx integrity functions

f1617fb

They behave similar to hash functions

INIT, APPEND_CONST_DATA, SHOW_MESSAGE, SHOW_MESAGE, FINISH calls

dbab988

Counted section internals and unit tests

aec86f7

Counted section commands

8280104

Storage Commands

0b11271

Transaction templates

d508b45

The code now pases original integration tests

Der. path is sent in INIT call instead of FINAL

cc7d25b

This way derivation path is available for DH encoding

DH commands

1e0b53b

DH encryption now encodes the result with base64

aa81895

Add Request funds transaction

f560dfb

Integrity check in END DH command + minor chanes

b87abed

Changing newfundsreq data content format, introduce error specific to integrity checks.

Add option to skip integrity check in DEVEL mode

39c4d04

Simplifying js parsing

86f2999

applying parse not validate as it is supposed

Finish BE->LE transition

397daa0

Derivation path is serializes LE Remove unnecessary endian functions

Recordobt transaction

d5b9493

List of hashes for integrity check is not updated at the moment...

New storage compare mode

2a8cb69

relatko added 3 commits January 27, 2023 15:53

Merge pull request #31 from vacuumlabs/documentation_and_cleanup

46b6c6b

Documentation and cleanup

Fix on device get app version test

43264af

Merge pull request #32 from vacuumlabs/documentation_and_cleanup

a897892

Fix on device get app version test

xchapron-ledger reviewed May 25, 2023

View reviewed changes

relatko added 6 commits May 30, 2023 12:07

Add guidelines enforcer

9bf9a7b

Easy code style fixes

1b228f8

eos_utils guideline_enforcer fix

76297da

Fix build

230398e

Minor testing fixes

760ad88

Update speculos container

ab29900

Vulnerability fixes

9fddc72

Fixed: - Missing input value validation - Potential missing secret wiping from stack after use - String manipulation - Pointer arithmetic on void pointer - Trivial swich-case statements were removed - Replaced certain other memset calls

relatko force-pushed the to_merge_with_LedgerHQ_1_0_5 branch from da25e74 to 9fddc72 Compare July 18, 2023 13:19

relatko added 11 commits September 6, 2023 11:41

Bump containers

d4cf90e

Remove stax from guidelines enforcer, add stax icon

937b5b9

Updating deprecated calls

314618b

Fix od Speculos NanoX tests

e167dea

Remove exceprions from public and private key code

5d55ca6

Refactor DH crypto functions

a3661c6

Move dependencies to non-throwing crypto modules

83703bf

Review changes

0f87fff

Consolidate crypto cleanup

7eb02b9

Incorporate review findings

7d38be1

Merge pull request #34 from vacuumlabs/to_merge_with_LedgerHQ_1_0_5b

e722ab0

Remove exceptions from public and private key code

xchapron-ledger reviewed Oct 30, 2023

View reviewed changes

src/keyDerivation.c Show resolved Hide resolved

relatko added 3 commits October 30, 2023 16:09

Bump containers, update issues

5c1e151

Merge pull request #35 from vacuumlabs/to_merge_with_LedgerHQ_1_0_5b

28f28c4

Bump containers, update issues

Merge branch 'LedgerHQdevelop' into to_merge_with_LedgerHQ_1_0_5

7df0ae6

xchapron-ledger mentioned this pull request Jan 17, 2024

App version 1.0.5 #14

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fully featured FIO app #12

Fully featured FIO app #12

Uh oh!

relatko commented Jan 27, 2023

Uh oh!

xchapron-ledger May 25, 2023

Uh oh!

xchapron-ledger May 25, 2023

Uh oh!

relatko Oct 31, 2023

Uh oh!

xchapron-ledger May 25, 2023

Uh oh!

relatko commented Jun 10, 2023

Uh oh!

tdejoigny-ledger commented Sep 4, 2023

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fully featured FIO app #12

Are you sure you want to change the base?

Fully featured FIO app #12

Uh oh!

Conversation

relatko commented Jan 27, 2023

Uh oh!

xchapron-ledger May 25, 2023

Choose a reason for hiding this comment

Uh oh!

xchapron-ledger May 25, 2023

Choose a reason for hiding this comment

Uh oh!

relatko Oct 31, 2023

Choose a reason for hiding this comment

Uh oh!

xchapron-ledger May 25, 2023

Choose a reason for hiding this comment

Uh oh!

relatko commented Jun 10, 2023

Uh oh!

tdejoigny-ledger commented Sep 4, 2023

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants