Conversation
yogh333
approved these changes
Oct 26, 2023
Contributor
There was a problem hiding this comment.
Ok but I did not understand exactly. Do you mean that as there are several Cargo.toml files in cargo-ledger tests directory, there is an issue when installing cargo-ledger ? It is weird, I was assuming that the Cargo.toml in the crate root is the only one to be considered...
Contributor
Author
|
Yep, see .rust-lang/cargo#3049 |
Contributor
|
@yhql this PR can be closed we are using the app-builder now in the CI, which already has cargo ledger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is currently failing because the new tests in
cargo-ledgercontain severalCargo.tomlfiles andcargo installusing a git link needs to know which one to use specifically