Code

Fix various problems#43

Code

Open

tjwoon wants to merge 7 commits intoLazarSoft:masterLazarSoft/jsqrcode:masterfrom tjwoon:fix-various-problemstjwoon/jsqrcode:fix-various-problemsCopy head branch name to clipboard

+47-30

Commits

Commits on Apr 1, 2015

• Fixed a bunch of undeclared local variables (which would escape to global scope...)

  tjwoon

  committed
  87c275a

  Copy full SHA for 87c275a

• Fixed: Various global variables were undeclared, which would be errors in "strict mode"

  tjwoon

  committed
  34d5ac2

  Copy full SHA for 34d5ac2

• Fixed: local variable name "eval" in rsdecoder.js caused problems on some (?) platforms, due to clashing with the built in "eval" function's name

  tjwoon

  committed
  3a0613c

  Copy full SHA for 3a0613c

• Fixed: (1) qrcode.decode was calling the callback synchronously, which is not how most callbacks work, and (2) the callback was not able to distinguish between successful and unsuccessful decode

  tjwoon

  committed
  ab0671e

  Copy full SHA for ab0671e

• Fixed: qrcode.decode did not call the callback if the image fails to load

  tjwoon

  committed
  ec91077

  Copy full SHA for ec91077

• Changed the way we call qrcode.callback to a backwards-compatible method (see ab0671e)

  tjwoon

  committed
  ff1c4f3

  Copy full SHA for ff1c4f3

• Fixed incorrect comment about file-local variables in 34d5ac2 (in my local copy I have them in file-local scope, but that does not apply in this repository)

  tjwoon

  committed
  6c6f8ac

  Copy full SHA for 6c6f8ac