Skip to content

fix: use path-only dependency for testing utils #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 11, 2025

Conversation

MegaRedHand
Copy link
Collaborator

@MegaRedHand MegaRedHand commented Apr 10, 2025

Fixes #

What Changed?

This PR fixes the cargo publish error we got on previous releases (run logs here):

  2025-02-06T14:09:32.528381Z ERROR  failed to release package

Caused by:
    failed to publish eigen-crypto-bls:     Updating crates.io index
    error: all dependencies must have a version specified when publishing.
    dependency `eigen-crypto-bn254` does not specify a version
    Note: The published dependency will use the version from crates.io,
    the `path` specification will be removed from the dependency declaration.

This error was due to some crates having cyclic dev-dependencies. We fix those by removing the version from the dev-dependency, leaving the path only, as specified in this issue: rust-lang/cargo#4242 (comment).

Reviewer Checklist

  • New features are tested and documented
  • PR updates the changelog with a description of changes
  • PR has one of the changelog-X labels (if applies)
  • Code deprecates any old functionality before removing it

@MegaRedHand MegaRedHand added the changelog-ignore PR is allowed to skip the changelog check label Apr 11, 2025
@MegaRedHand MegaRedHand marked this pull request as ready for review April 11, 2025 16:53
@MegaRedHand MegaRedHand enabled auto-merge (squash) April 11, 2025 17:48
@MegaRedHand MegaRedHand merged commit 4e2cdc6 into dev Apr 11, 2025
10 of 13 checks passed
@pablodeymo pablodeymo deleted the fix-cyclic-dependency-on-publish branch April 11, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-ignore PR is allowed to skip the changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants