feat: Initial project setup with Lambda timeout middleware and comprehensive documentation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hensive documentation - Add LambdaTimeoutLinkMiddleware for Lambda timeout-aware request cancellation - Add ApplicationBuilder extension method UseLambdaTimeoutLinkedCancellation() - Create comprehensive documentation structure with examples and best practices - Set up GitHub Actions for CI/CD (build, test, docs deployment) - Configure solution structure with proper organization - Add CLAUDE.md for future AI assistance context 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Create test project LayeredCraft.Lambda.AspNetCore.HostingExtensions.Tests - Add project reference to main library - Configure xUnit test runner settings - Add to solution structure in test folder 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add mkdocs.yml with Material theme configuration - Add requirements.txt for Python documentation dependencies - Add custom CSS styling for LayeredCraft branding - Configure navigation, search, and code highlighting - Enable dark/light theme toggle and responsive design 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove docs/assets/css/extra.css (not needed, follows CDK constructs pattern) - Remove extra_css reference from mkdocs.yml - Keep only Jekyll style.scss to match existing LayeredCraft documentation pattern - Align with CDK constructs repo structure using Material theme defaults 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Update requirements.txt to match CDK constructs versions exactly - Replace git-revision-date-localized plugin with minify plugin - Remove pymdown-extensions dependency (included with mkdocs-material) - Fix GitHub Actions build error with missing plugin 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR establishes the foundational structure for LayeredCraft Lambda ASP.NET Core Hosting Extensions, implementing a comprehensive Lambda timeout middleware with full documentation and CI/CD infrastructure.
- Core implementation of
LambdaTimeoutLinkMiddlewarefor intelligent timeout handling - Complete project setup with solution structure, documentation, and CI/CD pipelines
- Comprehensive documentation site with middleware guides and real-world examples
Reviewed Changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/LayeredCraft.Lambda.AspNetCore.HostingExtensions/Middleware/LambdaTimeoutLinkMiddleware.cs | Core middleware implementation for linking Lambda timeout with HTTP request cancellation |
| src/LayeredCraft.Lambda.AspNetCore.HostingExtensions/Extensions/ApplicationBuilderExtensions.cs | Extension method for easy middleware integration |
| src/LayeredCraft.Lambda.AspNetCore.HostingExtensions/LayeredCraft.Lambda.AspNetCore.HostingExtensions.csproj | Main library project file with dependencies |
| test/LayeredCraft.Lambda.AspNetCore.HostingExtensions.Tests/ | Test project setup with placeholder tests |
| docs/ | Complete documentation structure with middleware guides and examples |
| Solution and build files | Project organization, CI/CD workflows, and package configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...etCore.HostingExtensions.Tests/LayeredCraft.Lambda.AspNetCore.HostingExtensions.Tests.csproj
Show resolved
Hide resolved
- Add 12 complete unit tests covering all middleware functionality - Fix critical middleware bug in timeout vs client disconnect detection - Implement robust cancellation token registration with timestamps - Add short-circuit optimization for expired Lambda timeouts - Create comprehensive test infrastructure with AutoFixture specimen builders - Add convention-based parameter naming for different test scenarios - Enhance HttpContextSpecimenBuilder for Lambda context simulation - Add RequestDelegateSpecimenBuilder for delegate behavior testing - Verify proper token linking, restoration, and response handling - Test constructor validation, null checks, and edge cases 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 27 out of 29 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }; | ||
| } | ||
|
|
||
| private static HttpContext CreateDefaultHttpContext(ISpecimenContext context, bool hasLambdaContext = true, bool responseStarted = false, bool preCancelled = false) |
There was a problem hiding this comment.
This method has too many boolean parameters which makes it difficult to understand the intended behavior from call sites. Consider using an options pattern or separate factory methods for different scenarios.
Comment on lines
+22
to
+38
| return parameterName switch | ||
| { | ||
| // For tests that need to capture the token during execution | ||
| "capturingnext" or "capturingdelegate" => CreateCapturingRequestDelegate(), | ||
|
|
||
| // For tests that just need to verify it was called | ||
| "trackingnext" or "trackingdelegate" => CreateTrackingRequestDelegate(), | ||
|
|
||
| // For timeout cancellation testing | ||
| "timeoutdelegate" or "timeoutcancelling" => CreateTimeoutCancellingDelegate(), | ||
|
|
||
| // For client disconnect cancellation testing | ||
| "disconnectdelegate" or "disconnectcancelling" => CreateClientDisconnectDelegate(), | ||
|
|
||
| // Default: simple delegate that just completes | ||
| _ => CreateSimpleRequestDelegate() | ||
| }; |
There was a problem hiding this comment.
Using parameter names with string matching creates brittle test dependencies. Consider using an enum or attribute-based approach to specify the desired delegate behavior more explicitly.
… coverage - Add Microsoft.Testing.Extensions.CodeCoverage v17.14.2 for code coverage reporting - Enables coverage analysis with Microsoft Testing Platform (MTP) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR establishes the initial project setup for LayeredCraft Lambda ASP.NET Core Hosting Extensions, implementing a comprehensive Lambda timeout middleware with full documentation and CI/CD pipeline.
Changes
Core Implementation
UseLambdaTimeoutLinkedCancellation()for easy integrationDocumentation
Project Setup
Key Features
Test plan
dotnet build🤖 Generated with Claude Code