🗞️ feat: add ONFT721Enumerable to onft-evm #1184
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
This PR introduces the
ONFT721Enumerable
contract to theonft-evm
library, extending the functionality ofONFT721Core
by integrating OpenZeppelin'sERC721Enumerable
. This enhancement allows for enumeration of tokens owned by an address and all tokens within the contract, providing developers with advanced querying capabilities for ONFTs.Key Features:
ONFT721Core
withERC721Enumerable
:tokenOfOwnerByIndex
andtokenByIndex
.Usage Considerations:
_allTokens
,_allTokensIndex
,_ownedTokens
,_ownedTokensIndex
) to track tokens globally and per owner._allTokens
and_ownedTokens
._allTokens
and_ownedTokens
._ownedTokens
for both sender and recipient.For projects sensitive to gas costs, careful evaluation is necessary to determine whether the enumeration features outweigh the added costs.