Remove Hardcoded ID #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanTheMan827
force-pushed
the
remove-hardcoded-id
branch
from
6fad251 to
6c00c49
Compare
Contributor
Author
|
When or if #53 is merged, I'll rebase this on top of that. |
DanTheMan827
force-pushed
the
remove-hardcoded-id
branch
from
6c00c49 to
3c33fe1
Compare
DanTheMan827
force-pushed
the
remove-hardcoded-id
branch
from
3c33fe1 to
0ade5be
Compare
Contributor
Author
|
I refactored this PR so that it doesn't include the commits from #53 |
Lauriethefish
approved these changes
Jul 2, 2025
Owner
Lauriethefish
left a comment
Lauriethefish
left a comment
There was a problem hiding this comment.
Generally happy with these changes, happy to merge if there's nothing else you'd edit.
Contributor
Author
|
I haven’t had any issues specifically related to the functionality of this PR. Anything else would probably be feature additions. |
Owner
|
I can't rebase right now but if you rebase this branch, resolving the conflicts, I'll merge it |
This allows for the use of alternate package identifiers so that a developer could have more than one copy of the game installed at once.
DanTheMan827
force-pushed
the
remove-hardcoded-id
branch
from
0ade5be to
16e1407
Compare
Contributor
Author
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the use of alternate package identifiers so that a developer could have more than one copy of the game installed at once.