LibWeb/IDB: Apply default cursor direction#6484
Merged
gmta merged 1 commit intoLadybirdBrowser:masterfrom Oct 17, 2025
Merged
Conversation
konradekk
reviewed
Oct 16, 2025
stelar7
force-pushed
the
direction-defaults
branch
from
61d4bbe to
bab660e
Compare
IDBGetAllOptions is supposed to have a default value for direction. When the value passed is not a potentially valid key range, we need to default the direction argument, and not assume its set Spec issue: w3c/IndexedDB#478
stelar7
force-pushed
the
direction-defaults
branch
from
bab660e to
d2838cb
Compare
gmta
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are supposed to use a default value for direction in the case we have a
IDBGetAllOptionsobject, so lets actually do that.Fixes remaining tests on https://wpt.live/IndexedDB/idbobjectstore_getAllKeys-options.any.html
Related spec bug: w3c/IndexedDB#478