Improve WGS84 displacement functions#127
Open
MartinSollie wants to merge 1 commit intoLSTS:developfrom
Open
Conversation
oysstu
reviewed
Mar 18, 2026
| double c_wgs84_a = 6378137.0; | ||
| double c_wgs84_e2 = 0.00669437999013; | ||
| double p = Math.sqrt(xyz[0] * xyz[0] + xyz[1] * xyz[1]); | ||
| double lat_sin = Math.sin(Math.toRadians(lld[1])); |
There was a problem hiding this comment.
Not sure if this will ever get merged, but this line should use lld[0]. It currently uses longitude here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More accurate WGS84 displace functions matching the implementation in DUNE from LSTS/dune#194