Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noh test script fixes #318

Closed
wants to merge 2 commits into from
Closed

Noh test script fixes #318

wants to merge 2 commits into from

Conversation

jmpearl
Copy link
Collaborator

@jmpearl jmpearl commented Dec 6, 2024 •
edited
Loading

Summary

  • This PR is a bugfix for Noh test failing with MFV, FSISPH, and CRSKPH
  • It does the following:
    • adds minor fixes to Noh scripts
    • fixes MFV in GSPHHydros.py
    • adds MFV test to ensure construction doesn't break

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

@jmpearl
fixing Noh tests for MFV and FSISPH
29711ac 
fsisph had a bad input, mfv needed the update in the GSPHHydros.py file for the new H-update package paradigm
@jmpearl
updating CRKSPH constructor in Noh 3d
045d728
@jmpearl jmpearl changed the title Bugfix/gsph fsisph ci fix Noh test script fixes Dec 6, 2024
@jmpearl jmpearl requested review from jmikeowen and ldowen December 6, 2024 05:52
@jmpearl jmpearl closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen Awaiting requested review from jmikeowen

@ldowen ldowen Awaiting requested review from ldowen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmpearl