Fix ENABLE_DEV_BUILD #306
Merged
Fix ENABLE_DEV_BUILD #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikeowen
previously approved these changes
Oct 4, 2024
mdavis36
requested changes
Oct 8, 2024
.gitlab/specs.yml
Outdated
| @@ -9,7 +9,7 @@ | |||
| .gcc_mvapich2: | |||
| variables: | |||
| SPEC: 'gcc@$GCC_VERSION^mvapich2' | |||
| EXTRA_CMAKE_ARGS: '-DENABLE_DOCS=On -DENABLE_WARNINGS_AS_ERRORS=On' | |||
| EXTRA_CMAKE_ARGS: '-DENABLE_DOCS=On -DENABLE_WARNINGS_AS_ERRORS=On -DENABLE_DEV_BUILD=On' | |||
There was a problem hiding this comment.
Could we move this to a different config, we build gcc_mvapich2 as our release build so testing for the dev build with it isn't ideal. Maybe clang_mavapich2, or gcc_spectrum?
mdavis36
previously approved these changes
Oct 8, 2024
jmikeowen
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ENABLE_DEV_BUILDENABLE_DEV_BUILDthat prevented it from exporting or required special lists/logicENABLE_DEV_BUILDto ensure it will not break as oftenToDo :
RELEASE_NOTES.mdwith notable changes.