Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce reinstall times #304

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Reduce reinstall times #304

merged 4 commits into from
Oct 3, 2024

Conversation

ldowen
Copy link
Collaborator

@ldowen ldowen commented Sep 18, 2024 •
edited
Loading

Summary

  • This PR is a refactoring of the Spheral virtual environment creation routines.
  • It does the following:
    • Removes the python venv and package file copy calls from spheral-setup-env.in.
    • Perform the python venv directly from CMake.
    • Make package file copy function a CMake install to avoid unnecessary copies.
    • Properly exclude unnecessary files from the TPL python packages.
    • Reduces reinstall times by 5x.
    • Fixes bug with ENABLE_DEV_BUILD not installing individual targets

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#107)
  • LLNLSpheral PR has passed all tests.

@mdavis36 mdavis36 mentioned this pull request Sep 27, 2024
Open
3 tasks
@ldowen ldowen merged commit 8f84b7e into develop Oct 3, 2024
1 check passed
@ldowen ldowen deleted the feature/faster_virtual_env_install branch October 3, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen jmikeowen approved these changes

@mdavis36 mdavis36 mdavis36 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldowen @jmikeowen @mdavis36