Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang compiler warnings #301

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Fix clang compiler warnings #301

merged 4 commits into from
Aug 22, 2024

Conversation

adayton1
Copy link
Member

@adayton1 adayton1 commented Aug 22, 2024 •
edited
Loading

Summary

  • This PR is a bugfix
  • It does the following:
    • Fixes clang compiler warnings about inconsistent use of the "override" keyword
    • Cleans up Axom includes

ToDo :

@adayton1 adayton1 requested review from ptsuji, mdavis36 and ldowen August 22, 2024 00:04
@adayton1 adayton1 changed the title Fix compiler warnings Fix clang compiler warnings Aug 22, 2024
@adayton1 adayton1 requested a review from jmikeowen August 22, 2024 21:58
jmikeowen
jmikeowen approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@adayton1 adayton1 merged commit a696f9a into develop Aug 22, 2024
1 check passed
@adayton1 adayton1 deleted the feature/dayton8/optimize_builds branch August 22, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen jmikeowen approved these changes

@ldowen ldowen ldowen approved these changes

@ptsuji ptsuji Awaiting requested review from ptsuji

@mdavis36 mdavis36 Awaiting requested review from mdavis36

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adayton1 @jmikeowen @ldowen