Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exposing DEM variable to python #300

Merged
merged 2 commits into from
Aug 29, 2024
Merged

exposing DEM variable to python #300

merged 2 commits into from
Aug 29, 2024

Conversation

jmpearl
Copy link
Collaborator

@jmpearl jmpearl commented Aug 21, 2024 •
edited
Loading

Summary

  • This PR is a bug fix
  • It does the following:
    • LinearSpringDEM variable maxOverlap wasn't implemented in PYB11

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

@jmpearl jmpearl self-assigned this Aug 21, 2024
@jmpearl jmpearl requested a review from jmikeowen August 21, 2024 16:18
jmikeowen
jmikeowen approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More Python interface exposed is good!

@jmpearl jmpearl merged commit f9d06ca into develop Aug 29, 2024
1 check passed
@jmpearl jmpearl deleted the bugFix/dem_pybind branch August 29, 2024 17:26
@mdavis36
Copy link
Collaborator

LLNLSpheral tests need to pass before merging next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen jmikeowen approved these changes

Assignees

@jmpearl jmpearl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmpearl @mdavis36 @jmikeowen