Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate variable ROM #9

Merged
merged 44 commits into from
Jan 16, 2024
Merged

Separate variable ROM #9

merged 44 commits into from
Jan 16, 2024

Conversation

dreamer2368
Copy link
Collaborator

@dreamer2368 dreamer2368 commented Jan 10, 2024

ROMHandler went through a major refactoring in order to support separate variable ROM.

  • ROMHandler is changed to an abstract class ROMHandlerBase. Only MFEMROMHandler class is available to use in practice.
  • If separate_variable, ROMHandler stores basis for each variable in each reference component as a separate basis tag.
  • MFEMROMHandler now have array dom_basis of pointers for each subdomain block basis.
  • ROMHandler supports various projection/lifting-up operation on Operator and Vector.
  • MultiBlockSolver supports ROM projection for separate variable basis.
  • StokesSolver run supremizer enrichment in order to keep inf-sup condition, if separate_variable_basis.
  • Anomaly is detected for StokesSolver and SteadyNSSolver FOM, when heterogeneous component meshes are used. Bug fix includes:
    • Now ComponentTopologyHandler enforces all the component meshes to have the same FiniteElementCollection.
    • SteadyNSSolver enforces all the component meshes to have the same element type.

@dreamer2368 dreamer2368 changed the title Var rom Separate variable ROM Jan 16, 2024
@dreamer2368 dreamer2368 marked this pull request as ready for review January 16, 2024 23:15
@dreamer2368 dreamer2368 merged commit 0d82970 into main Jan 16, 2024
2 checks passed
@dreamer2368 dreamer2368 deleted the var-rom branch July 9, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant