Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bayesian Optimization into HiOp #711

Merged
merged 7 commits into from
Mar 14, 2025
Merged

Add Bayesian Optimization into HiOp #711

merged 7 commits into from
Mar 14, 2025

Conversation

nychiang
Copy link
Collaborator

@nychiang nychiang commented Mar 11, 2025

This PR adds a GP-based Bayesian Optimization (BO) solver into HiOp.

  • Implementation of a abstract GP class and an inherited class
  • Implementation of a BO algorithm
  • Implementation of an example

@nychiang nychiang requested review from cnpetra and thartland March 11, 2025 16:05
@nychiang nychiang self-assigned this Mar 11, 2025
@nychiang nychiang added this to the Bayesian Optimization milestone Mar 11, 2025
@nychiang nychiang added documentation new feature use this label to mark requests for new features under "Issues" labels Mar 11, 2025
Copy link
Collaborator

@cnpetra cnpetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the comments. I think we should merge this without updating the user manual.

Copy link
Collaborator

@thartland thartland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great first time and don't have any big concerns that prevent me from approving this but do have a few questions. Are the smtProblems omitted in order to reduce the amount of code in hiopbbpy? Should we change the name from hiopbbpy to hioppy? While hiopbbpy is intended for use in black box BO optimization. If we eventually make hiop algorithms available in the hiopbbpy interface then it seems that a user could just use of the hiop algorithms in any python application.

@cnpetra cnpetra marked this pull request as ready for review March 14, 2025 16:49
@cnpetra cnpetra self-requested a review March 14, 2025 16:50
@cnpetra cnpetra merged commit ff0686b into develop Mar 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation new feature use this label to mark requests for new features under "Issues"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants