Use enable_language(HIP) #702
Conversation
host-configs/llnl/toss_4_x86_64_ib_cray/[email protected][email protected]_hip.cmake
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris White <[email protected]>
| @@ -41,32 +47,7 @@ message(STATUS "ROCM path: ${ROCM_PATH}") | |||
| message(STATUS "HIP version: ${hip_VERSION}") | |||
|
|
|||
| # AMDGPU_TARGETS should be defined in the hip-config.cmake that gets "included" via find_package(hip) | |||
| # This file is also what hardcodes the --offload-arch flags we're removing here | |||
| if(DEFINED AMDGPU_TARGETS) | |||
There was a problem hiding this comment.
It seems like there's no longer a point for having AMDGPU_TARGETS.
There was a problem hiding this comment.
Or is it used internally by hip's CMake setup?
There was a problem hiding this comment.
I don't see it in CMake's source, maybe it is in the FindRocm source. I would have expected this to only be used as a backwards compatiblity and maybe just set the CMake variable.
There was a problem hiding this comment.
I could do backwards compatibility but I think removal might be best since we are going to be having breaking BLT changes soon
…o feature/enable_language_hip
host-configs/llnl/toss_4_x86_64_ib_cray/[email protected]_hip.cmake
Outdated
Show resolved
Hide resolved
| @@ -87,14 +68,10 @@ else() | |||
| endif() | |||
|
|
|||
| blt_import_library(NAME blt_hip | |||
| COMPILE_FLAGS ${_blt_hip_compile_flags} | |||
There was a problem hiding this comment.
I just noticed this: _blt_hip_compile_flags is still set above but it is now unused. Is the fix for --rocm-path with crayftn no longer needed? @davidbeckingsale @white238
Inspired by #596 , but doesn't support hipcc