-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3D ELVIRA MIR #1535
Open
BradWhitlock
wants to merge
62
commits into
develop
Choose a base branch
from
feature/whitlock/mir_elvira3d
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
3D ELVIRA MIR #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recording that are not consistent.
…nhanced Polyhedra so it is easier to get faces. Added more clip routines for polyhedra.
…ot providing good results for one of its datasets.
…inally, I change the serial algorithm so it better matches the base algorithm.
…against the original volume.
…ode cleanup changes.
…to make it achievable when making fragments.
… on Release builds.
… we accessed its node ids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
axom::mir::ElviraAlgorithm
class with support for 3D structured meshes. The algorithm operates as before in 2D but when it clips, it makes polyhedra and uses them to compute volumes. Polyhedral fragments are clipped off of mixed material zones according to planes that are determined for each material in the zone. The fragments are consolidated into a new Blueprint unstructured topology and a new matset is created for the resulting clean zones. Filters were added to improve the generated polyhedral topology so like points and faces are merged. The updated algorithm is tested via new CI programs that test ELVIRA 3D and some of the helper filter algorithms. The test infrastructure was also improved.