Implement sidre-to-conduit copies #1510
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual fix is on another branch, but I can't wait for it to be merged.
It's failing. Maybe because non-Umpire allocators are not working right or Group isn't using it right.
Also disable test copying in/out of Umpire. This check needs to wait for proper support for that kind of copy, which is being performed on another branch.
change transfer_allocator method name to transferTo. Also use call-back to return View-specific allocator.
gunney1
force-pushed
the
feature/gunney/copy-sidre-to-conduit
branch
from
6764c24 to
41c15d7
Compare
gunney1
force-pushed
the
feature/gunney/copy-sidre-to-conduit
branch
from
582bbad to
46bb8a7
Compare
BradWhitlock
reviewed
Apr 2, 2025
| } | ||
| @endcode | ||
| */ | ||
| struct ConduitMemory |
There was a problem hiding this comment.
It looks like is does the same job as ConduitAllocateThroughAxom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Group::deepCopyToConduitandView::deepCopyToConduitThe goal of this change is toward supporting transparent switching between sidre and conduit. This is the state of conduit-sidre hierarchy copies, with this PR.