Fix header order issue with hip and vectorization #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adayton1
approved these changes
Apr 3, 2025
rhornung67
approved these changes
Apr 3, 2025
MrBurmark
commented
Apr 4, 2025
this file requires shfl_sync calls
This makes more sense as intrinsics depend on the device and not on any of the policies.
Also fix the order of guards again multiple inclusion
|
Manually testing my hacky way of building as CXX seems to build them as CXX and link them as HIP but then the executable can't find the hip runtime unless I load the module. So I'll probably take those tests out and make an issue for us to try to test them some other way. |
…ip_warp_size_tensor
This reverts commit 681de23.
adayton1
reviewed
Apr 8, 2025
adayton1
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Explicitly use RAJA_HIP_WAVESIZE in the tensor arch hip files to avoid a header order issue.
Design review (for API changes or additions---delete if unneeded)
On (date), we reviewed this PR. We discussed the design ideas:
This PR implements 1. and 3. It leaves out 2. for the following reasons