-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caliper support #1773
Caliper support #1773
Conversation
TODO: Compare the Caliper results with standard timers. |
This isn't quite done, but I do want to trigger the CI to double check that we are passing test across the board. |
Everything should now be addressed, thanks team! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, which you can choose to ignore.
@LLNL/raja-core , I think we should be good to go now -- I also turned on Any objections to merging if this comes out green? |
Remember to remove when we remove support for the old plugin name
I explicitly added a "getPlugin" test and manually confirmed that it fails if the "getPlugin" loading code is not there. |
Awesome! Thanks! |
Initial pass at building with Caliper and plugins:
To build:
Example run:
Example output:
Observations:
Caliper timings are consistent with the RAJA timer function.
//----------------
TODO:
This PR changes KernelName -> Name