Skip to content

Conversation

@michaelmckinsey1
Copy link

We noticed some of the CUDA and HIP policies appear to be identical, despite attempting to define different layouts. It would appear that all of these layouts currently execute the GZD policy.

  • Should only the ArgumentId nesting match the ordering of the sequential policy or does the ExecPolicy nesting also need to change?
  • I noticed a similar looking issue for LPlusTimes.h, which I have not corrected here, and I have not checked the policies in other files.

@pearce8
Copy link

pearce8 commented Nov 4, 2025

@rchen20 @MrBurmark Can you help figure out what these policies should look like? There is definitely a copy paste error making all policies behave the same, but @michaelmckinsey1 wasn't sure he is fixing this correctly. This also seems to be different than the kernel in RAJAPerf.

@MrBurmark
Copy link
Member

MrBurmark commented Nov 4, 2025

This does look like a copy paste that was never fixed up. Looking at other policies I can see that the layout is supposed to give the order of the loops, but that doesn't include the moment loop. Due to the tensor contraction nature of the kernel I would think that the moment loop always has to use a sequential policy for correctness. @rchen20 do you know how these are supposed to map to the GPU?

@rchen20
Copy link
Member

rchen20 commented Nov 4, 2025

I am not sure . . . let me show this to John Loffeld, he would know.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes are for testing

@michaelmckinsey1 michaelmckinsey1 marked this pull request as draft November 11, 2025 18:10
@rchen20
Copy link
Member

rchen20 commented Nov 11, 2025

After discussion with John, there was a correct ordering some time before we added the HIP backend, and the error likely occurred as HIP policies were added. When I have some time, I'll go through commits and try to find the right one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants