Add TryFrom integer conversions for NonZero scalars#238
Merged
Conversation
- Add ZeroScalar error type for when converting zero to NonZero - Implement TryFrom<integer> for Scalar<S, NonZero> that fails on zero - Keep existing infallible From<integer> for Scalar<S, Zero> - Add comprehensive test coverage for the new conversions
LLFourn
force-pushed
the
more-try-from
branch
from
22179bb to
7208720
Compare
nickfarrow
reviewed
Nov 19, 2025
| let scalar = Scalar::<S, Zero>::from_bytes(bytes).unwrap(); | ||
|
|
||
| // Check if value is zero | ||
| if value == 0 { |
Collaborator
There was a problem hiding this comment.
nit: could check this first for an early return before doing the computation. Maybe negligible, and maybe the compiler would optimize this
nickfarrow
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds that fails when the input is zero, with a proper error type.