log and fail fast on Rocket bind/listen failures (bind target + nonzero exit) #63
+92
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
PASS [ 43.267s] (2/3) lit_node::test toxiproxy::perf_tests::load_with_50ms_latency_single_link |
Garandor
changed the title
glitch003
approved these changes
Jan 13, 2026
Contributor
glitch003
left a comment
glitch003
left a comment
There was a problem hiding this comment.
nice improvement to get these logs out on failure. very annoying to diagnost with no logs for that.
…nzero exit) - Log configured Rocket listener targets (address/port/proto/role) during startup. - Launch multiple Rocket listeners with FuturesUnordered and fail fast on the first launch() error (avoids join_all hanging if at least one server starts up successfully). - On bind/listen failure, log a clear error including the resolved bind target details. - Treat launcher launch() errors as fatal in the Rocket engine (panic) so startup failure becomes explicit and exits non-zero. - Add explicit error log if launch() is called before ignite() (should not happen).
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improve error handling and diagnostics for Rocket HTTP server launch failures.
Why
Previously, Rocket launch errors (such as port bind failures) were silently ignored, making it difficult to diagnose server startup issues. This change ensures that launch failures are properly logged and propagated, causing the application to exit with a non-zero status code.
Risks
join_all(wait for all futures to exit) was changed and now exitslit-nodewhen a single rocket fails to launch and with nonzero exit, which could have downstream effects on systemd and other supervisors.