-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/node 4931 implement lit actions for keysets (datil support!) #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: keysets
Are you sure you want to change the base?
Feature/node 4931 implement lit actions for keysets (datil support!) #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds support for Datil and Naga keysets in Lit Actions by introducing a keySetId parameter across the entire Lit Actions SDK and related infrastructure. This enables Lit Actions to work with different keyset configurations, particularly supporting the Datil testnet environment.
Key changes:
- Added
keySetIdparameter to all signing, encryption, and PKP permission operations in the JavaScript SDK - Updated protocol buffer schemas to include
keySetIdfield in all relevant request types - Modified Rust backend to handle
keySetIdin action execution and removed it from the top-levelJsonExecutionRequest - Updated test infrastructure to support both Naga and Datil testnet types with appropriate keyset configurations
Reviewed changes
Copilot reviewed 29 out of 31 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
rust/lit-node/lit-node/tests/lit_action_scripts/*.js |
Added keySetId parameter to signing, encryption, and decryption operations in test scripts |
rust/lit-node/lit-node/tests/integration/session_sigs.rs |
Removed key_set_id parameter from function signatures and usage (now passed via js_params) |
rust/lit-node/lit-node/tests/integration/lit_actions.rs |
Added Datil testnet support with new test cases and is_datil flag for keyset selection |
rust/lit-node/lit-node/tests/integration/integration_tests.rs |
Minor formatting improvements (whitespace cleanup) |
rust/lit-node/lit-node/tests/common/*.rs |
Updated helper functions to pass keySetId via js_params instead of as separate parameter |
rust/lit-node/lit-node/src/functions/action_client.rs |
Added keySetId parameter handling across all operations (signing, encryption, PKP permissions) |
rust/lit-node/lit-node-testnet/src/testnet/contracts_repo.rs |
Updated cache path generation to include network state differentiation |
rust/lit-node/lit-node-testnet/src/end_user/datil_pkp.rs |
Set default Datil keyset ID for Datil PKPs |
rust/lit-node/lit-node-core/src/models/request.rs |
Removed key_set_id field from JsonExecutionRequest (moved to js_params) |
rust/lit-actions/tests/it.rs |
Added key_set_id field to test request structures |
rust/lit-actions/grpc/schema/lit_actions.proto |
Added key_set_id field to all relevant protobuf message types |
rust/lit-actions/ext/js/02_litActionsSDK.js |
Added keySetId parameter with default value datilKeySetId to all SDK functions |
rust/lit-actions/ext/bindings.rs |
Updated Rust bindings to pass key_set_id parameter from JavaScript to native code |
rust/lit-actions/docs/*.d.ts and api_docs.md |
Added keySetId parameter documentation to TypeScript definitions and markdown docs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rust/lit-node/lit-node/tests/lit_action_scripts/fail_sign_non_hashed_message.js
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
PASS [ 43.108s] (3/3) lit_node::test toxiproxy::perf_tests::load_with_no_latency |
Pull request overview
This pull request adds support for Datil and Naga keysets in Lit Actions by introducing a
keySetIdparameter across the entire Lit Actions SDK and related infrastructure. This enables Lit Actions to work with different keyset configurations, particularly supporting the Datil testnet environment.Key changes:
keySetIdparameter to all signing, encryption, and PKP permission operations in the JavaScript SDKkeySetIdfield in all relevant request typeskeySetIdin action execution and removed it from the top-levelJsonExecutionRequestNOTES
datillit actions. ( to be increased )datil+nagakeysets used simultaneous, though the code is designed to support this. ( to be added )