-
Notifications
You must be signed in to change notification settings - Fork 78
modify random wallet generation BaseProvider.ts #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Robert Mads Christensen <[email protected]>
|
Signed-off-by: Robert Mads Christensen <[email protected]>
Signed-off-by: Robert Mads Christensen <[email protected]>
During my testing, the only change that should be need to the From:
To:
|
Co-authored-by: awisniew207 <[email protected]> Signed-off-by: Robert Mads Christensen <[email protected]>
Co-authored-by: awisniew207 <[email protected]> Signed-off-by: Robert Mads Christensen <[email protected]>
Co-authored-by: awisniew207 <[email protected]> Signed-off-by: Robert Mads Christensen <[email protected]>
Co-authored-by: awisniew207 <[email protected]> Signed-off-by: Robert Mads Christensen <[email protected]>
Signed-off-by: Robert Mads Christensen <[email protected]>
Signed-off-by: Robert Mads Christensen <[email protected]>
Signed-off-by: Robert Mads Christensen <[email protected]>
Signed-off-by: Robert Mads Christensen <[email protected]>
lgtm! 👍 This solution will prevent a wallet extension from opening in the browser. A more thorough fix would be refactoring the |
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: