Respect snap_name parameter for in-progress backups#314
Open
blampe wants to merge 1 commit intoLINBIT:masterfrom
Open
Respect snap_name parameter for in-progress backups#314blampe wants to merge 1 commit intoLINBIT:masterfrom
blampe wants to merge 1 commit intoLINBIT:masterfrom
Conversation
This was referenced Sep 18, 2022
webpav
approved these changes
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, if any backups were in progress then other snapshot operations driven by the CSI would break.
Concretely, the bug is:
Edit: there also appears to be an issue with
getInProgressBackups, because the bug persists even when all backups are successful. I'm not looking into that because the scope of this PR already addresses my immediate problem.Refs piraeusdatastore/linstor-csi#174