-
Notifications
You must be signed in to change notification settings - Fork 2
feat(core): implement 3D tetrahedra grid generation #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #372 +/- ##
==========================================
+ Coverage 84.95% 85.44% +0.48%
==========================================
Files 73 75 +2
Lines 10238 10574 +336
==========================================
+ Hits 8698 9035 +337
+ Misses 1540 1539 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the algorithm or give a ref?
Is it really something you want to put in core?
I plan on adding a figure to the documentation before merging. The structure is essentially a basic cut of hexahedral cells into 5 tetra each (4 orthocentric, and one regular at the center adjacent to the other four). This component is repeated along each axis (with an alternating symmetry to get a conformal mesh) to build the grid.
I thought about this too. I think we could have a grid generation module in
1 is ok, 2 is slightly annoying IMO. We could make the new interface a function (e.g. |
The CI fails due to a docker failure to fetch taplo, same tests are successful in local. I'm not sure I can make a cleaner PR, both changes are linked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for making you do a lot of changes in this PR but I think it will be clearer on the long run.
Description
title
Necessary follow-up