Skip to content

adding a button to change the relationship type and adding the zero-to-many relationship. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: notation
Choose a base branch
from

Conversation

HansMarcus01
Copy link

The first changes were made to make the modeler support both identifying and non-identifying relationships, and to include more cardinalities in the modeler.

Copy link

@pabloem pabloem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please address comments before merging.

@@ -158,6 +158,83 @@ export function CrowOO(
)
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain what is a zero-to-many relationship in a comment?
and perhaps add a screenshot to the PR

@@ -134,7 +134,7 @@ const es = {
swap: "Intercambiar",
one_to_one: "Uno a uno",
one_to_many: "Uno a muchos",
many_to_one: "Muchos a uno",
Zero_to_much: "Zero a Muchos",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Zero_to_much: "Zero a Muchos",
zero_to_many: "Cero a muchos",

@@ -141,7 +141,7 @@ const en = {
swap: "Swap",
one_to_one: "One to one",
one_to_many: "One to many",
many_to_one: "Many to one",
zero_to_many: "Cero to many",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
zero_to_many: "Cero to many",
zero_to_many: "Zero to many",

@@ -141,7 +141,7 @@ const en = {
swap: "Swap",
one_to_one: "One to one",
one_to_many: "One to many",
many_to_one: "Many to one",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you deleting many_to_one? we dont need it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants