Skip to content

Removing cardinality start from subtypes relations #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HansMarcus01 merged 1 commit into from
Oct 22, 2025
Merged

Removing cardinality start from subtypes relations #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/components/EditorCanvas/Relationship.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,11 @@ export default function Relationship({
const cardinalityStartOffset = 30;
const cardinalityEndOffset = 37;

// If this is a subtype relationship we generally don't want to show a
// parent cardinality on the parent table. Use an empty string when
// passing to notation renderers so they skip drawing it.
const displayedCardinalityStart = data.subtype ? "" : cardinalityStart;

if (pathRef.current) {
const totalPathLength = pathRef.current.getTotalLength();

Expand Down Expand Up @@ -778,7 +783,7 @@ export default function Relationship({
strokeWidth={2}
/>
{/* Show parent/child notations for all relationships */}
{parentFormat &&
{parentFormat && !data.subtype &&
parentFormat(
cardinalityStartX,
cardinalityStartY,
Expand All @@ -796,7 +801,7 @@ export default function Relationship({
cardinalityStartX,
cardinalityStartY,
direction,
cardinalityStart,
displayedCardinalityStart,
cardinalityEnd,
settings.showCardinality,
isVertical,
Expand All @@ -811,7 +816,7 @@ export default function Relationship({
cardinalityStartX,
cardinalityStartY,
direction,
cardinalityStart,
displayedCardinalityStart,
cardinalityEnd,
settings.showCardinality,
isVertical,
Expand Down