This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Change animation setup #496
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merges the TransitionAnimator and ImageAnimator into one Animator enum. It has the advantage of using less memory than before, because we always allocated the same amount of TransitionAnimator and ImageAnimator anyway, and Animator has the same size as TransitionAnimator. It also cleans up a bit of the code, since we can remove some duplicated things.
We can use output_name as an unique id, so that we do not need to wrap everything around `Rc` and `RefCell`. In some places, this will entail some extra cost in filtering the `wallpaper` iterator for just those that are part of a group. However, because the vast majority of our users will probably not have anything beyong 4 outputs, the cost of this is pretty low. On the other hand, previously, every access to a wallpaper incurred one extra pointer load from the `Rc`, and one extra branch for the `RefCell`. On the other hand, this should improve memory usage and cache access patterns. This means overall this should also improve performance, or at the very least not negatively affect it very much.
Instead, the animation group is determined by its index in the animation vector. This reduces the amount of data we need to keep track of and simplifies a few things.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.