This repository was archived by the owner on Oct 31, 2025. It is now read-only.
delete build.nix and the nix tests
#420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From what I have seen from other projects, they do not maintain a `build.nix` file themselves, nor do they test specifically with `nix`. I believe this should be under the purview of the `nix` maintainers. I do not know enough about `nix`'s packaging system to reliably maintain this. Furthermore, it has been poluting our CI for a while, since it takes much longer to run than the other tests. If there is ever any problem building in `nix`, we can fix that as it comes up. Alternatively, if someone else wishes to create an automatic CI test for `nix`, go ahead. But I am simply turning it off again the moment it stops working and I can't fix it within an hour.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I have seen from other projects, they do not maintain a
build.nixfile themselves, nor do they test specifically withnix. I believe this should be under the purview of thenixmaintainers.I do not know enough about
nix's packaging system to reliably maintain this. Furthermore, it has been poluting our CI for a while, since it takes much longer to run than the other tests.If there is ever any problem building in
nix, we can fix that as it comes up. Alternatively, if someone else wishes to create an automatic CI test fornix, go ahead. But I am simply turning it off again the moment it stops working and I can't fix it within an hour.